Improve N-Queens input validation and solution counting clarity#1871
Open
MayankSharma-2812 wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
Improve N-Queens input validation and solution counting clarity#1871MayankSharma-2812 wants to merge 1 commit intoTheAlgorithms:masterfrom
MayankSharma-2812 wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
MayankSharma-2812
requested review from
appgurueu and
raklaptudirm
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1871 +/- ##
==========================================
- Coverage 85.91% 85.91% -0.01%
==========================================
Files 379 379
Lines 19778 19777 -1
Branches 3015 3017 +2
==========================================
- Hits 16993 16992 -1
Misses 2785 2785 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved input validation for board size and clarified solve() behavior by removing misleading return values while preserving solution counting logic.